-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix degree and employment form fields #5034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5034 +/- ##
==========================================
- Coverage 94.05% 94.04% -0.01%
==========================================
Files 500 500
Lines 22972 22972
Branches 932 932
==========================================
- Hits 21607 21605 -2
- Misses 1267 1268 +1
- Partials 98 99 +1
Continue to review full report at Codecov.
|
@umarmughal824 - Visually, the screenshots you shared look great! I think the longest country is: |
@briangrossman this is how it looks like |
Great. Thanks!!! 👍 |
@annagav could you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we achieve the same result on mobile view without also modifying the full desktop view of the card?
@briangrossman do you think should we should update the desktop screens or should we keep them intact as per the attached screenshots. |
If possible, I think it would be better to have this PR only only affect the mobile view. Ideally, the desktop would continue to look like it currently does on the production site, rather than modifying it: |
@briangrossman this is how it used to be before: and here is in this PR: |
4ef87c3
to
d7fc92e
Compare
@briangrossman @annagav I have updated the screenshots see in the PR description. I have updated the tablet version too as it seems problematic. |
@umarmughal824 Thanks! I see what you're saying with the wrapping of the city field for the tablet version. Thanks for sharing that. I think it's fine the way you have it now. The most important thing is that you've fixed the options in the pulldown so they don't overlap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Pre-Flight checklist
What are the relevant tickets?
fixes #5019
What's this PR do?
Can't select some countries in pulldowns on phone in portrait mode
How should this be manually tested?
Just see the country field on the profile page by adding degree and employment
Screenshots (if appropriate)
MOBILE
TABLET
DESKTOP