-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing pearson communication code #4765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 94.39% 88.09% -6.31%
==========================================
Files 512 193 -319
Lines 23349 8230 -15119
Branches 967 902 -65
==========================================
- Hits 22040 7250 -14790
+ Misses 1206 885 -321
+ Partials 103 95 -8
Continue to review full report at Codecov.
|
Can you change the typo in the PR title and your commits? It should be "pearson" with an "a". I'm just planning ahead for when we might have to search the repo for this change. |
e816ead
to
45f9e26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally looking good but a few extra things we should get rid of:
- Move
exams/pearson/constants.py
toexams/constants.py
- In
exams/tasks.py
remove thePEARSON_*
constants - Remove unused pearson exam settings from
settings.py
- Remove unused pearson exam env var definitions from
app.json
@annagav looks like there's a test failure due to the removal of some |
@rhysyngsun I fixed the tests. Thank you! |
What are the relevant tickets?
Fix #4754
What's this PR do?
Remove legacy pearson code
Should also reomve the following config variables:
How should this be manually tested?
nothing should break