-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import exam grades: ignore no score rows #4759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4759 +/- ##
==========================================
- Coverage 94.41% 94.39% -0.03%
==========================================
Files 512 512
Lines 23344 23349 +5
Branches 967 967
==========================================
Hits 22040 22040
- Misses 1201 1206 +5
Partials 103 103
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 , Just a small change suggested. Feel free to merge on your ease.
FYI, Since i didn't have the sample file, i was able to test it after generating my own csv file with required columns.
'grade': row['grade'], | ||
'percentage_grade': float(row['score']) / 100.0 if row['score'] else 0, | ||
'percentage_grade': score / 100.0 if row['score'] else 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'percentage_grade': score / 100.0 if row['score'] else 0, | |
'percentage_grade': score / 100.0 if score else 0, |
What are the relevant tickets?
Fix #4756
What's this PR do?
Update the management command to ignore records that do not have a score.
How should this be manually tested?
Run the management command:
./manage.py import_edx_exam_grades <file>