Removed UI validators from PrivacyTab validator callback

This changes the privacy tab validation callback on only validation
profile fields, and not check UI state. This fixes a bug where default
values for the UI state could prevent the user from being able to save a
profile on the privacy tab.

static/js/components/PrivacyTab.js

@@ -8,9 +8,7 @@ import {
   combineValidators,
   personalValidation,
   educationValidation,
-  educationUiValidation,
   employmentValidation,
-  employmentUiValidation,
   privacyValidation,
 } from '../util/validation';
 import type { Profile } from '../flow/profileTypes';
@@ -50,9 +48,7 @@ class PrivacyTab extends ProfileFormFields {
                 combineValidators(
                   personalValidation,
                   educationValidation,
-                  educationUiValidation,
                   employmentValidation,
-                  employmentUiValidation,
                   privacyValidation
                 )
               }

static/js/containers/ProfilePage_test.js

@@ -387,7 +387,7 @@ describe("ProfilePage", function() {
     });
   });
 
-  it(`validates education and employment switches when saving the ${lastPage}`, () => {
+  it('does not validate education and employment switches when saving the privacy page', () => {
     return renderComponent(lastPage).then(([, div]) => {
       // close all switches and remove all education so we don't get validation errors
       let receivedProfile = Object.assign({}, USER_PROFILE_RESPONSE, {
@@ -408,10 +408,7 @@ describe("ProfilePage", function() {
       });
 
       return confirmSaveButtonBehavior(updatedProfile, {button: button}, true).then(state => {
-        assert.deepEqual(state.profiles[SETTINGS.username].edit.errors, {
-          [`education_${HIGH_SCHOOL}_required`]: `High school is required if switch is set`,
-          work_history_required: "Work history is required if switch is set"
-        });
+        assert.deepEqual(state.profiles[SETTINGS.username].edit.errors, {});
       });
     });
   });