Remove menuStyleWithHeight, pass this from SelectField instead

mitodl · Jun 22, 2016 · 08aac4e · 08aac4e
1 parent 57a4298
commit 08aac4e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/static/js/components/AutoComplete.js b/static/js/components/AutoComplete.js
@@ -439,9 +439,6 @@ class AutoComplete extends Component {
     }
 
     this.requestsList = requestsList;
-    let menuStyleWithHeight = Object.assign({}, menuStyle, {
-      maxHeight: menuHeight
-    });
 
     const menu = open && requestsList.length > 0 && (
       <Menu
@@ -453,7 +450,7 @@ class AutoComplete extends Component {
         initiallyKeyboardFocused={true}
         onItemTouchTap={this.handleItemTouchTap}
         onMouseDown={this.handleMouseDown}
-        style={Object.assign(styles.menu, menuStyleWithHeight)}
+        style={Object.assign(styles.menu, menuStyle)}
         menuHeight={menuHeight}
         listStyle={Object.assign(styles.list, listStyle)}
         requestsList={requestsList}

diff --git a/static/js/components/inputs/SelectField.js b/static/js/components/inputs/SelectField.js
@@ -64,6 +64,7 @@ export default class SelectField extends React.Component {
   static defaultProps = {
     autocompleteStyleProps: {
       menuHeight: 300,
+      menuStyle: {maxHeight: 300},
       fullWidth: true
     }
   };