Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service account authentication #67

Merged
merged 2 commits into from
Oct 22, 2017

Conversation

kunanit
Copy link
Contributor

@kunanit kunanit commented Oct 22, 2017

Updates methods for service account authentication:

  • Removes use of depreciated SignedJwtAssertionCredentials from oauth2client (resolves SignedJwtAssertionCredentials from oauth2client is depreciated #66).
  • Google recommends using .json keyfiles instead of .p12, so support for .json service account keyfiles is implemented. If a .json keyfile is used then the auth_service_acct setting in edx2bigquery_config is not required.
  • So that those with .p12 keyfiles don't have to generate a new keyfile and update settings, authentication with .p12 keyfiles is reimplemented, but uses the oauth2client.service_account.from_p12_keyfile method. The HAS_CRYTO variable / "Try installing OpenSSL" warning is removed because oauth2client already throws a custom exception prompting the user to install PyOpenSSL if it is not found.

@ichuang ichuang merged commit 5c07833 into mitodl:master Oct 22, 2017
@ichuang
Copy link
Contributor

ichuang commented Oct 22, 2017

Thanks! Been meaning to do this for awhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignedJwtAssertionCredentials from oauth2client is depreciated
2 participants