Removed native date picker by making input type text [#94367846] #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdpinch
changed the title
|
@pwilkins can you review? |
| @@ -124,5 +124,18 @@ | |||
| 'dateFormat': 'yy-mm-dd', | |||
| 'autoclose': true | |||
| }); | |||
| $('.datepair .date').change(function() { | |||
There was a problem hiding this comment.
Why aren't we just using the datepickers methods for grabbing the date object? https://api.jqueryui.com/datepicker/
There was a problem hiding this comment.
@carsongee now using date picker api to grab date, the aim of this PR is to disallow date years like 0001,0002.... Currently date pickers allows date format like 0001-2-23 but javascript and date picker assume it as 2001-2-23, So text field shows date 0001-2-23 but date picker dialog show it as 2001-2-23. It is ambiguous.
in this PR I made date consistent i.e same on both date picker dialog and text field. When use adds date in text field like 0001-2-23 app convert it to 2001-2-23. A valid year.
|
Fixed in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Working for MIT ODL. Previously app was showing 2 date pickers on chrome browser and one date picker on reset of browsers, I have changed input type=date to type=text, now it is showing only customise date picker.
Added a validation, If user enters a date less then 100 , app with change it to val + 2000, means if user enters 0001-2-21 on focus out it will change it to 2001-2-21
jazkarta#63
jazkarta#30
#21
EDX https://github.com/edx/edx-platform/pull/7946
@carsongee @pdpinch @pwilkins