Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to polyfill.io #703

Merged
merged 2 commits into from
Jun 25, 2024
Merged

remove references to polyfill.io #703

merged 2 commits into from
Jun 25, 2024

Conversation

adhintz
Copy link
Contributor

@adhintz adhintz commented Jun 25, 2024

The polyfill.io website has been reported to serve malicious code. (reference and GitHub issue)

I do not think there is a need for these es6 polyfills because es6 has been supported in browsers for the past 9 years.

@mhils
Copy link
Member

mhils commented Jun 25, 2024

Thank you for flagging this, greatly appreciated!

@mhils mhils merged commit 726b8f2 into mitmproxy:main Jun 25, 2024
12 checks passed
@adhintz
Copy link
Contributor Author

adhintz commented Jun 25, 2024

Thank you for the quick merge, appreciate it!

@mhils
Copy link
Member

mhils commented Jun 25, 2024

pdoc 14.5.1 is out. Advisory is at GHSA-5vgj-ggm4-fg62, I've requested a CVE from GitHub. Thank you again for the report!

I will now do some digging how this made it in the in the first place. I typically avoid CDNs where possible, but I vaguely recall that this was tricky with MathJax.

@mhils
Copy link
Member

mhils commented Jun 25, 2024

After doing some more digging, we included polyfill.io here because that is what's recommended on https://www.mathjax.org/#gettingstarted. I've flagged the latest developments at mathjax/MathJax-docs#334.

We're still using jsdelivr for MathJax and Mermaid diagrams if those features are enabled (they are off by default). I'm much less worried about jsdelivr, but we should take a look again if there is a good way for us to embed both of them into pdoc without massively bloating our output.

@mhils
Copy link
Member

mhils commented Jun 25, 2024

@adhintz: I've credited you for reporting this over at GHSA-5vgj-ggm4-fg62. There's probably a button for you somewhere to accept that. Thank you again! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants