add: support for in-Markdown Mermaid diagrams #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support and documentation for rendering Mermaid diagrams by default.
Bumps
markdown2
tov2.4.8
.I'd also advocate for listing
markdown2
as a dependency and pinning the version there instead of vendoring a copy. I think it keeps things neater and in their own wheelhouses; I don't see a reason to treat it differently than the other deps, unless there's a proven track record of incompatibilities with other tools people might use in tandem / I acknowledge it would probably add some dependency maintenance overhead (which might be a valid reason itself).Closes #524.