This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
add ec2.VpcAttribute and ec2.ModifyVpcAttribute #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @deoxxa! The tests are are pretty straight forward...we basically mock XML and assert request data and response data. You can see a ton of examples of that in This looks good to me, though. If you can add tests in a follow-up PR that'd be great, in the meantime I'll merge it in. |
pearkes
added a commit
that referenced
this pull request
Aug 20, 2014
add ec2.VpcAttribute and ec2.ModifyVpcAttribute
preflightsiren
pushed a commit
to preflightsiren/goamz
that referenced
this pull request
Oct 27, 2014
add ec2.VpcAttribute and ec2.ModifyVpcAttribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the box. I tried to keep the same idioms as the
ModifyInstancefunction with theSet...fields. I think, long term, that they're a bad idea, but that's not a matter for right now. I don't know quite how to add tests, so I'd love it if someone gave me a bit of a rundown on how to go about doing that.