-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude non-expert-validated plays. #3
base: master
Are you sure you want to change the base?
Conversation
Update -- testing this PR on the Review app, indeed the rake task aborts because of the same foreign key constraint issue.
So a next step would be to find out which registers are still referencing non-validated plays, and remap them to validated ones. |
Hi Jamie - It may help to know that the warehouse plays_dim table uses the same ids as the original plays table. Here are the bad plays:
And, the bad register entries:
Hope this helps! C |
@christopheryork -- Yep, that makes sense. I will request an update from Sara as to which plays those registers should point to instead. Thanks for confirming, and for those queries! |
Sounds good. Good luck! |
This filters out play which are not expert_validated when the warehouse script is run.
It occurs to me that there could be a related problem in which existing tickets sales, or registers, are still referring to these non-expert validated plays, and which therefore need to be re-mapped to their expert validated equivalents.
I will (and you can) test the PR without affecting the staging or production databases, run the warehouse rake task on this heroku app: https://dashboard.heroku.com/apps/cfrp-staging-pr-3