This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Fix chatStream from crashing when incomplete lines are streamed from Axios #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chatStreamcurrently breaks as the chunks being yielded from Axios are not guaranteed to be complete lines. This leads to a crash onyield JSON.parse(chunkData)(line 184 of the original code) as parsing fails.This
lineGeneratorshould live in a separate file and have its own unit tests, but I don't see any tests nor other files in this repository. Opening this for discussion.