Support timeout for commands #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands can now be stopped after the specified timeout. The default behaviour of no timeouts is kept the same. Users wanting to opt into this feature must set a new DefaultRunner with properly set values. Related to mistifyio#70.
|
Hello @mmlb, this is the implementation I asked about. What do you think? The original PR had comments about Send and Receive, I have not used those ZFS commands but I think users can choose for themselves whether to timeout said commands or not? Tried to go for something similar like httpclient or slog which have a default client/logger and users can override them. Ideally instead of overwriting the default they could create a custom one and use it but that would involve bigger changes and I wanted to keep it simple for starters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands can now be stopped after the specified timeout. The default behaviour of no timeouts is kept the same. Users wanting to opt into this feature must set a new DefaultRunner with properly set values.
Related to #70.