Add timeout to zfs/zpool commands #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmlb @joshie @EdwardBetts Could you please review the PR ? |
|
Special care will have to be taken for send/recv since the upper bounds for these commands may not be predictable in advance. |
|
yes if we use this, we can always unset the environment variable before send/receive command and set it again, else by default there is no timeout for any command. |
avnish30jn
force-pushed
the
timeout-for-commands
branch
from
66b2563
to
4ab411c
Compare
|
@trisk i have updated to the code to set the timeout for all zfs/zpool commands except zfs send/receive commands as it cannot be predicted in advance. |
mmlb
force-pushed
the
timeout-for-commands
branch
from
4ab411c
to
2e1ae07
Compare
mmlb
changed the title
mmlb
force-pushed
the
timeout-for-commands
branch
from
2e1ae07
to
21a1df2
Compare
|
In 2024 this can easily be done with CommandContext. You can even send SIGTERM and wait for a while before sending SIGKILL to attempt a clean exit. If implemented would it get merged? |
|
@antonag32 sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr adds the support to add timeout to the commands that we run.
Eg:- export COMMAND_TIMEOUT=5m will set context to the command
supported timeout values are the ones that can be parsed by golang time.ParseDuration method.
Supported time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".