Virtual-Tour: Rotate before and after a new node, chain nodes #933

Mr-Kanister · 2023-04-13T12:53:48Z

For my usecase I added the following features to the Virtual-Tour-Plugin:

it is possible to overwrite the position to which the camera rotates to, when a link is clicked. This is useful when two links are too close to each other and thus the distance between them (to prevent them from overlapping) needs to be increased. To further ensure that the camera still animates to the right place, this option has been added.
it is possible to specify a position to which the viewer rotates to, after the new node has been loaded. This is useful when you want to highlight specific things at a node in the tour.
it is possible to automatically jump to another node after the first one has loaded. With this option it is possible to create "chains" of nodes, which is especially useful when a place is not of great importance in the tour, but it is helpful for orientation to include it as an intermediate step (e.g. on a stair landing, or in an anteroom).

I'd be very happy, if these would make it upstream. Please tell me, what you think about the implementation.

Merge request checklist

All lints and tests pass.
If needed, the documentation has been updated. (Not yet)

mistic100

rotateBeforeLoad only works with position, when using gps the user won't know what is the final computed position. It would be better to have an offsetPosition which will be added to the link position (hence moving the marker/arrow but not where the viewer is rotated before going to the next node)
rotateAfterLoad and nextNodeId are advanced features that can be easily implemented with event listeners, it is be much more versatile

(the following code changes requests won't be needed once the above modifications are made)

mistic100 · 2023-04-15T14:14:14Z

packages/virtual-tour-plugin/src/VirtualTourPlugin.ts

@@ -342,6 +342,7 @@ export class VirtualTourPlugin extends AbstractConfigurablePlugin<

        const fromNode = this.state.currentNode;
        const fromLinkPosition = fromNode && fromLink ? this.__getLinkPosition(fromNode, fromLink) : null;
+        const rotateBeforeLoad = fromNode && fromLink && fromLink.rotateBeforeLoad ? fromLink.rotateBeforeLoad : fromLinkPosition;


Suggested change

const rotateBeforeLoad = fromNode && fromLink && fromLink.rotateBeforeLoad ? fromLink.rotateBeforeLoad : fromLinkPosition;

const rotateBeforeLoad = fromLink?.rotateBeforeLoad ?? fromLinkPosition;

mistic100 · 2023-04-15T14:14:44Z

packages/virtual-tour-plugin/src/VirtualTourPlugin.ts

@@ -432,6 +433,24 @@ export class VirtualTourPlugin extends AbstractConfigurablePlugin<

                return true;
            })
+            .then(() => {
+                const currentNode = this.state.currentNode;
+                const rotateAfterLoad = fromNode && fromLink && fromLink.rotateAfterLoad ? fromLink.rotateAfterLoad : null;


Suggested change

const rotateAfterLoad = fromNode && fromLink && fromLink.rotateAfterLoad ? fromLink.rotateAfterLoad : null;

const rotateAfterLoad = fromLink?.rotateAfterLoad;

mistic100 · 2023-04-15T14:16:08Z

packages/virtual-tour-plugin/src/VirtualTourPlugin.ts

@@ -432,6 +433,24 @@ export class VirtualTourPlugin extends AbstractConfigurablePlugin<

                return true;
            })
+            .then(() => {


there is not point of chaining a promise here, the code can be put on line 433

mistic100 · 2023-04-15T14:17:20Z

packages/virtual-tour-plugin/src/VirtualTourPlugin.ts

+                        }
+                    })
+                    .then(() => {
+                        const nextNodeId = fromNode && fromLink ? fromLink.nextNodeId : null;


Suggested change

const nextNodeId = fromNode && fromLink ? fromLink.nextNodeId : null;

const nextNodeId = fromLink?.nextNodeId;

Mr-Kanister · 2023-04-15T17:02:14Z

rotateAfterLoad and nextNodeId are advanced features that can be easily implemented with event listeners, it is be much more versatile

Do you mean those features shouldn't be implemented, or should they be implemented with a NodeChanged event listener?

mistic100 · 2023-04-15T17:03:23Z

Do you mean those features shouldn't be implemented, or should they be implemented with a NodeChanged event listener?

They shouldn't be implemented

…xtNodeId

Mr-Kanister · 2023-04-15T18:00:00Z

I can't really understand why the build fails, I implemented your requests.

mistic100 · 2023-04-15T18:11:57Z

don't worry that's on me, it is broken on the main branch too

github-actions · 2023-04-23T14:36:13Z

This feature/bug fix has been released in version 5.1.5.

Mr-Kanister added 5 commits April 13, 2023 13:07

Added rotateToPosition functionality in Virtual-Tour-Nodes and -Links

ab6761e

Fix lint not being successful

08f0cd4

Simplified: Set nextNodeId on a link, not on a node

07637cc

Simplified: Set rotateAfterLoad on a link, not on a node

1eeb07b

Fixed rotateBeforeLoad

1f969b8

mistic100 requested changes Apr 15, 2023

View reviewed changes

Changed rotateBeforeLoad to linkOffset. Reverted rotateAfterLoad & ne…

a3091f1

…xtNodeId

mistic100 added the feature label Apr 21, 2023

mistic100 added this to the 5.1.5 milestone Apr 21, 2023

mistic100 closed this in d01a892 Apr 21, 2023

Mr-Kanister mentioned this pull request Aug 1, 2023

"setCurrentNode" on "node-changed" event gets stuck #1028

Closed

mistic100 mentioned this pull request Aug 17, 2023

[Virtual Tour] More options for animation between nodes #1049

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtual-Tour: Rotate before and after a new node, chain nodes #933

Virtual-Tour: Rotate before and after a new node, chain nodes #933

Mr-Kanister commented Apr 13, 2023

mistic100 left a comment •

edited

Loading

mistic100 Apr 15, 2023

mistic100 Apr 15, 2023

mistic100 Apr 15, 2023

mistic100 Apr 15, 2023

Mr-Kanister commented Apr 15, 2023

mistic100 commented Apr 15, 2023

Mr-Kanister commented Apr 15, 2023

mistic100 commented Apr 15, 2023

github-actions bot commented Apr 23, 2023

	const rotateBeforeLoad = fromNode && fromLink && fromLink.rotateBeforeLoad ? fromLink.rotateBeforeLoad : fromLinkPosition;
	const rotateBeforeLoad = fromLink?.rotateBeforeLoad ?? fromLinkPosition;

	const rotateAfterLoad = fromNode && fromLink && fromLink.rotateAfterLoad ? fromLink.rotateAfterLoad : null;
	const rotateAfterLoad = fromLink?.rotateAfterLoad;

	const nextNodeId = fromNode && fromLink ? fromLink.nextNodeId : null;
	const nextNodeId = fromLink?.nextNodeId;

Virtual-Tour: Rotate before and after a new node, chain nodes #933

Virtual-Tour: Rotate before and after a new node, chain nodes #933

Conversation

Mr-Kanister commented Apr 13, 2023

mistic100 left a comment • edited Loading

Choose a reason for hiding this comment

mistic100 Apr 15, 2023

Choose a reason for hiding this comment

mistic100 Apr 15, 2023

Choose a reason for hiding this comment

mistic100 Apr 15, 2023

Choose a reason for hiding this comment

mistic100 Apr 15, 2023

Choose a reason for hiding this comment

Mr-Kanister commented Apr 15, 2023

mistic100 commented Apr 15, 2023

Mr-Kanister commented Apr 15, 2023

mistic100 commented Apr 15, 2023

github-actions bot commented Apr 23, 2023

mistic100 left a comment •

edited

Loading