fix(iOS-video): display video adaptater on iOS #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `playinline` to `playInline` to be able to read the panorama on iOS without using the native iOS viewer
|
Sounds about right https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement (it is not documented but listed in the compatibility table) |
|
This feature/bug fix has been released in version 4.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
playinlinetoplayInlineto be able to read the video panorama on iOS without using the native iOS viewer.Description
There is a bug for iOS devices using the video plugin due to the missing attribute
playinlineduring the html5 video tag creation #L161.Tests examples of the issue from the documentation using an iPhone on Chrome app:
Fix
I don't find good resources covering the issue. But it look like the attribute
playinlineshould be in camelCase #L161..This changes fix the issue as i was able to run video on iOS as on Android.
Merge request checklist
devand I am issuing the PR todev.