Bugfix: getWebGLCtx was returning false on supported environments #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm updating my code to use the new release of this library and I came across a compatibility problem with IE11 (not that we care a lot, but a lot of people on our website actually use it 😅).
Anyway, the visor was throwing an error indicating that WebGL was not supported, which was weird as we are using another library that uses it without any problem.
After taking a look at the code, it appears that the following fragment inside the
getWebGLCtx
method always returns after the first element inside thenames
array (some checks for the first "truthful").According to the HTMLCanvasStandard, the
getContext
method will just return null if the context is not supported, thus always returning true to the webgl context (the first one in the array) even if it's not supported.This PR changes the returning condition to check if the value is different from null.
Merge request checklist
dev
and I am issuing the PR todev