Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoplay option for videoLayer markers #1259

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Mr-Kanister
Copy link

These changes make it possible to disable the automatic playback of videoLayers. If you do this via an event listener and pause(), often it still throws unnecessary AbortError errors due to the autoplay policies of modern browsers.

To be backwards compatible, it defaults to autoplay enabled.

Merge request checklist

  • All lints and tests pass. If needed, new unit tests were added.
  • If needed, the documentation has been updated.

@mistic100 mistic100 added this to the 5.7.3 milestone Mar 7, 2024
@mistic100 mistic100 merged commit d72696e into mistic100:main Mar 7, 2024
3 checks passed
@mistic100
Copy link
Owner

For some reason on my computer, removing video.play() makes the autoplay not working at all.

So I will add

                    if (video.autoplay) {
                        video.play();
                    }

@Mr-Kanister
Copy link
Author

Sure, I was wondering why this call was there. Sorry I didn't ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants