Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen not working on WebKit Browsers (Safari MacOS, iPadOS) #850

Closed
ceage opened this issue Feb 2, 2023 · 3 comments
Closed

Fullscreen not working on WebKit Browsers (Safari MacOS, iPadOS) #850

ceage opened this issue Feb 2, 2023 · 3 comments
Labels
Milestone

Comments

@ceage
Copy link

ceage commented Feb 2, 2023

Describe the bug

I’ve noticed that with v5 I can no longer enter fullscreen on Safari on MacOS or iPadOS. This was working in versions v4 and lower before.

Error information is

TypeError: this.container.requestFullscreen is not a function. (In 'this.container.requestFullscreen()', 'this.container.requestFullscreen' is undefined)
[f] enterFullscreen - Viewer.ts:729
[f] toggleFullscreen - Viewer.ts:747
[E] onClick - FullscreenButton.ts:35
[f] (anonyme Funktion) - AbstractButton.ts:124

No issues for Firefox or Chrome/Edge, though. Could it be that there’s still a prefix needed for WebKit browsers as indicated here:https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen?retiredLocale=de?

Online demo URL

No response

Photo Sphere Viewer version

5.1.0

Plugins loaded

No response

OS & browser

Safari on MacOS 13.2 and iPadOS 16.3

Additional context

No response

@ceage ceage added the bug label Feb 2, 2023
@mistic100
Copy link
Owner

Safari is seriously the new Internet Explorer ! the only browser not supporting standard API.

I will re-add the fallbacks with "webkit" prefix but won't be able to test.

@ceage
Copy link
Author

ceage commented Feb 3, 2023

@mistic100 I agree ;-)
I am happy to test the fallback.

@mistic100 mistic100 added this to the 5.1.1 milestone Feb 3, 2023
mistic100 added a commit that referenced this issue Feb 3, 2023
mistic100 added a commit that referenced this issue Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This feature/bug fix has been released in version 5.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants