-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen of the container. #74
Comments
When posting a block of code use triple back-quote with language code (see your message I edited) I'll see why it's not done like this and if it has impacts. |
The confusion between parent and container exists because I had to include another layer of DOM to simplify relative positioning, and in the process I forgot to migrate this particular lines of code. |
@AlexandreDelan for the sake of simplicity I had to revert back to the old version. |
In my project, I've added a top bar.
In the html code, this new div has been added in the container div (the one given in the container option).
This issue is the fullscreen is not done another "container". The name of the variable is confusing as
"option.container != this.container".
see bellow.
Anyway I suggest the following update to toggle fullscreen on option.container and not this.container.
Before:
After - replacing this.container by this.parent:
The text was updated successfully, but these errors were encountered: