Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved link arrow #646

Closed
AdamMiltonBarker opened this issue Mar 2, 2022 · 10 comments
Closed

Improved link arrow #646

AdamMiltonBarker opened this issue Mar 2, 2022 · 10 comments
Labels
Milestone

Comments

@AdamMiltonBarker
Copy link

AdamMiltonBarker commented Mar 2, 2022

Hi mate. Is it possible to modify the arrow image used in the links? Also is it possible to place the links on the floor or on a wall as in the example provided for Kuula, I have not been able to find this info in the documentation and assume it is not yet possible, Maybe wrong?

https://kuula.co/share/NqTY1/collection/7qlkm

@mistic100
Copy link
Owner

mistic100 commented Mar 2, 2022 via email

@mistic100
Copy link
Owner

mistic100 commented Mar 2, 2022

Actually you could achieve something like this with an "imageLayer" marker, but it won't be automatic, you will need to fine tune the position of each marker and have different images for each orientations

@AdamMiltonBarker
Copy link
Author

AdamMiltonBarker commented Mar 2, 2022

@mistic100 cheers. Do you have an example of using the markers plugin for the links, or have I missed it ?

@mistic100
Copy link
Owner

https://photo-sphere-viewer.js.org/plugins/plugin-virtual-tour.html#configuration renderMode and markerStyle options.

And you just need to add the markers plugin without any special configuration.

@AdamMiltonBarker
Copy link
Author

OK thanks will check it out, last one sorry, people have been saying on mobile that the images are too zoomed in, I can't seem to find a zoom configuration, although I am guessing I have missed it :D

@mistic100
Copy link
Owner

@AdamMiltonBarker
Copy link
Author

Ok thank you for pointing me in the right direction, once I get this done will send you the link so you can see your hard work in action :)

@mistic100
Copy link
Owner

I am currently woking on the "imageLayer" markers to be able to declare the orientation.

Example of a perfectly round image which is oriented.
imageLayer-marker

@AdamMiltonBarker
Copy link
Author

Honestly mate the whole thing is great, but making that change above will massively improve it, a lot, that will be a great feature mate! I am having issues with tours its just not flowing right and when you have multiple arrows, the orientation navigating around is a bit weird, I will add more info after but its my birthday today so not doing much, I feel with a few improvements this library will be unbeatable!

@mistic100 mistic100 added this to the 4.5.2 milestone Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This feature/bug fix has been released in version 4.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants