Fix #851 map: display issue when calling minimize()+hide()

mistic100 · Feb 5, 2023 · b751717 · b751717
1 parent 46813fe
commit b751717
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/examples/plugin-map.html b/examples/plugin-map.html
@@ -36,7 +36,7 @@
                         defaultZoom: 40,
                         // position: 'top left',
                         // maxZoom: 300,
-                        // compassImage: null,
+                        // overlayImage: null,
                         // static: true,
                         // visibleOnLoad: false,
                         hotspots: [

diff --git a/packages/map-plugin/src/components/MapComponent.ts b/packages/map-plugin/src/components/MapComponent.ts
@@ -211,7 +211,7 @@ export class MapComponent extends AbstractComponent {
                 this.state.forceRender = true;
                 break;
             case 'transitionend':
-                if (!this.state.maximized && this.overlay) {
+                if (!this.state.maximized) {
                     this.overlay.style.display = '';
                 }
                 this.state.forceRender = false;
@@ -253,9 +253,17 @@ export class MapComponent extends AbstractComponent {
         return this.state.visible && !this.state.collapsed;
     }
 
-    override show(): void {
+    override show() {
         super.show();
         this.update();
+        if (!this.state.maximized) {
+            this.overlay.style.display = '';
+        }
+    }
+
+    override hide() {
+        super.hide();
+        this.state.forceRender = false;
     }
 
     /**
@@ -324,7 +332,7 @@ export class MapComponent extends AbstractComponent {
 
         utils.toggleClass(this.container, 'psv-map--maximized', this.state.maximized);
 
-        if (this.state.maximized && this.overlay) {
+        if (this.state.maximized) {
             this.overlay.style.display = 'none';
         }