Fix #658 video: error on destroy

mistic100 · Mar 24, 2022 · 7909967 · 7909967
1 parent a2a84c3
commit 7909967
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/plugins/settings/index.js b/src/plugins/settings/index.js
@@ -91,7 +91,7 @@ export class SettingsPlugin extends AbstractPlugin {
    * @package
    */
   destroy() {
-    delete this.settings;
+    this.settings.length = 0;
 
     super.destroy();
   }

diff --git a/src/plugins/video/index.js b/src/plugins/video/index.js
@@ -125,9 +125,6 @@ export class VideoPlugin extends AbstractPlugin {
     this.psv.off(CONSTANTS.EVENTS.PANORAMA_LOADED, this);
     this.psv.off(CONSTANTS.EVENTS.KEY_PRESS, this);
 
-    this.progressbar?.destroy();
-    this.overlay?.destroy();
-
     delete this.autorotate;
     delete this.progressbar;
     delete this.overlay;