Improve injectability of the library and ability to swap UIActivityIndicator in and out #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panajev
commented
Mar 5, 2017
Panajev
commented
- Improved compatibility with UIActivityIndicator by providing a protocol compatible with both.
- Using a common protocol allows the user to make his implementation decoupled from this spinner or UIKit's default one.
- Improved compatibility with MBProgressHUD by implementing intrinsicContentSize and content size invalidation.
Panajev
force-pushed
the
features/ActiivtyIndicatorCompatibility
branch
3 times, most recently
from
ced31ed
to
4b5070b
Compare
|
@misterwell this also fixed the Travis integration issue due to some outdated commands in the Example podfile and the requirement for iOS8+ which was not explicit everywhere. |
* Improved compatibility with UIActivityIndicator by providing a protocol compatible with both. * Using a common protocol allows the user to make his implementation decoupled from this spinner or UIKit's default one. * Improved compatibility with MBProgressHUD by implementing intrinsicContentSize and content size invalidation. Signed-off-by: Goffredo Marocchi <[email protected]>
Panajev
force-pushed
the
features/ActiivtyIndicatorCompatibility
branch
from
4b5070b
to
7c54fb5
Compare
Panajev
changed the title
|
Hello @misterwell, is there anything more that needs to be done before submitting the PR? I am sorry, but I am not aware of extra requirements or a Slack channel to discuss this first or something... |
|
This also fixes #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.