リモートにNSFWが効かないのを修正 #2348
Merged
リモートにNSFWが効かないのを修正 #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
なるほど、そういうことだったんですね！ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/syuilo/misskey/issues/2238, https://github.com/syuilo/misskey/issues/2326 の修正
Misskey <=> Mastodon で伝わらないのは、
Misskey: sensitiveはAttachmentに付けてる のに対して、
Mastodon: sensitiveはNote全体に付けてる ため。
→AP送信時に、どれか1つの添付ファイルがsensitiveなら Noteにsensitiveを付けるように変更
→AP受信時に、Noteがsensitiveなら 全部の添付ファイルにsensitiveを付けるように変更
Misskey => Misskey で伝わらないのは、
別の理由(Imageにはsensitive付けてるがDocumentには付けてない)だが
上の修正で包括されるのでこの部分は未修正。
NSFW, 非NSFWが混在している場合に、
リモートへは(Misskey向けでも)全ファイルNSFWで伝わるが
通信相手がMastodonかMisskeyを区別できないので仕方ない。
新しく送受信したものからNSFWが反映される