Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 投稿フォームの設定メニューを改良 #14804

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 投稿ボタン横の「リアクションの受け入れ」ボタンを消して「その他」ボタンにした
  • 「その他」のポップアップ内に・・・
    • 文字数カウントを復活させた
    • 「リアクションの受け入れ」メニューを入れた
    • 投稿フォームのリセットボタンを入れた

image

Why

Fix #14794
Fix #10785

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 68.16143% with 213 lines in your changes missing coverage. Please review.

Project coverage is 19.40%. Comparing base (04b37a1) to head (d7ca816).

Files with missing lines Patch % Lines
...es/frontend/src/components/MkPostFormOtherMenu.vue 0.00% 211 Missing and 1 partial ⚠️
packages/frontend/src/components/MkMenu.item.vue 99.76% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14804       +/-   ##
============================================
- Coverage    39.52%   19.40%   -20.13%     
============================================
  Files         1557      726      -831     
  Lines       196654   103514    -93140     
  Branches      3621      993     -2628     
============================================
- Hits         77736    20084    -57652     
+ Misses      118348    82878    -35470     
+ Partials       570      552       -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

投稿フォームの入力内容をクリアするボタン 残り文字数表示
2 participants