Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

federate with allowed hosts instead of blocking them #14671

Closed
wants to merge 1 commit into from

Conversation

boringcactus
Copy link

What

There is a bug in #14643 where new federated hosts are added to the blockedHosts instead of the federatedHosts.

Why

When I add federated hosts, I want to federate with them and not to block them.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 3, 2024
@KisaragiEffective
Copy link
Collaborator

Duplicate of #14662, I'm sorry!

Copy link
Contributor

github-actions bot commented Oct 3, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.79%. Comparing base (a3d236c) to head (b9c0b26).
Report is 209 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/server/api/endpoints/admin/update-meta.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14671      +/-   ##
===========================================
- Coverage    41.74%   39.79%   -1.96%     
===========================================
  Files         1549     1545       -4     
  Lines       196555   193742    -2813     
  Branches      2767     3591     +824     
===========================================
- Hits         82055    77100    -4955     
- Misses      113939   116079    +2140     
- Partials       561      563       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boringcactus boringcactus deleted the fix-allowlist branch October 3, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants