Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkRangeのタッチ操作時にtooltipが複数重なって表示されないように #14548

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 14, 2024

What

v-tooltipとos.popupの両方でツールチップを呼び出していたため、os.popup側だけに寄せた
Cherry-picked from taiyme#265

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih changed the title fix: MkRangeのタッチ操作時にtooltipが複数重なって表示されないように fix(frontend): MkRangeのタッチ操作時にtooltipが複数重なって表示されないように Sep 14, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 19.43%. Comparing base (0c6d1ec) to head (c1e18bc).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkRange.vue 0.00% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14548       +/-   ##
============================================
- Coverage    38.66%   19.43%   -19.24%     
============================================
  Files         1541      714      -827     
  Lines       192612   101028    -91584     
  Branches      3253      986     -2267     
============================================
- Hits         74474    19634    -54840     
+ Misses      117576    80849    -36727     
+ Partials       562      545       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyoshoka zyoshoka linked an issue Sep 14, 2024 that may be closed by this pull request
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

これだとマウスオーバーしたときに表示されなくならない?

@kakkokari-gtyih
Copy link
Contributor Author

これだとマウスオーバーしたときに表示されなくならない?

ホバー時にも出るようにした

@syuilo syuilo merged commit cd247b9 into misskey-dev:develop Sep 23, 2024
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 23, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-mkrange-tooltip branch September 23, 2024 15:14
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
)

* fix: directiveでのtooltip表示との競合を解消 (misskey-dev#265)

(cherry picked from commit 6d15d37)

* code style

* Update Changelog

* record origin

* fix: ホバー時にもツールチップが出るように

---------

Co-authored-by: CaffeinePower <[email protected]>
Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

タッチ操作でスライダの吹き出し表示が2重になる
3 participants