Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): #13929 の revert の revert #14546

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 14, 2024

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

syuilo and others added 16 commits September 14, 2024 11:41
(cherry picked from commit aab1c76)
(cherry picked from commit d9f3f0c)
(cherry picked from commit 1488b67)
(cherry picked from commit c08ccb6)
(cherry picked from commit cd665be)
(cherry picked from commit 3676ada)
(cherry picked from commit 27c7900)
(cherry picked from commit d3c1926)
(cherry picked from commit ed8eabb)
(cherry picked from commit 5c0ce01)
(cherry picked from commit 12bab1c)
@kakkokari-gtyih kakkokari-gtyih changed the title refactor(frontend): #13929 の revert の refactor(frontend): #13929 の revert の revert Sep 14, 2024
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft September 14, 2024 03:03
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 13.08411% with 558 lines in your changes missing coverage. Please review.

Project coverage is 19.51%. Comparing base (837a8e1) to head (4faa47f).
Report is 131 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/about.overview.vue 0.00% 21 Missing ⚠️
packages/frontend/src/boot/common.ts 0.00% 16 Missing ⚠️
...es/frontend/src/components/MkSignupDialog.form.vue 0.00% 16 Missing ⚠️
packages/frontend/src/ui/_common_/common.ts 0.00% 12 Missing ⚠️
...s/frontend/src/components/MkSignupDialog.rules.vue 0.00% 11 Missing ⚠️
packages/frontend/src/pages/timeline.vue 0.00% 11 Missing ⚠️
packages/frontend/src/pages/admin/index.vue 0.00% 10 Missing ⚠️
packages/frontend/src/pages/contact.vue 0.00% 10 Missing ⚠️
packages/frontend/src/scripts/upload.ts 9.09% 10 Missing ⚠️
...ges/frontend/src/components/MkVisitorDashboard.vue 0.00% 9 Missing ⚠️
... and 86 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14546      +/-   ##
===========================================
- Coverage    19.53%   19.51%   -0.03%     
===========================================
  Files          713      714       +1     
  Lines       100287   100529     +242     
  Branches       997      996       -1     
===========================================
+ Hits         19591    19614      +23     
- Misses       80152    80370     +218     
- Partials       544      545       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 17, 2024

これDraftなのはCI失敗以外の理由あるかしら

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 17, 2024

これDraftなのはCI失敗以外の理由あるかしら

#13929ではしゅいろさんがこれ関連の変更をやっている途中でrevertしたので、まだ出来上がってないんじゃないかというのもある
あと #14529 では、コレを含めた一連の変更について話している気がするのでというのもある

@syuilo
Copy link
Member

syuilo commented Sep 18, 2024

TASUKETE

@syuilo
Copy link
Member

syuilo commented Sep 19, 2024

Cypress謎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants