Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): instance infoページで不必要なapiリクエストが飛ぶのを抑止 #14515

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • モデレーションノート変更の検知をiAmModerator限定に変更
  • 型定義まわりの修正

Why

Fix #13919

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 19.97%. Comparing base (cdb0566) to head (8f4a58c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkChart.vue 0.00% 26 Missing ⚠️
packages/frontend/src/pages/instance-info.vue 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14515      +/-   ##
===========================================
- Coverage    19.97%   19.97%   -0.01%     
===========================================
  Files          725      725              
  Lines       100568   100579      +11     
  Branches      1047     1047              
===========================================
  Hits         20089    20089              
- Misses       79935    79946      +11     
  Partials       544      544              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 567acea into misskey-dev:develop Sep 6, 2024
18 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 6, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-13919 branch September 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants