Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL preview popup for local URL appears in the upper left corner #13555

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

anatawa12
Copy link
Member

What

ローカルURLのプレビューポップアップが左上に表示されるのを正しくリンクの位置になるようにした

Why

Additional info (optional)

image

これを治す

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (6b676a9) to head (df09cdb).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13555       +/-   ##
============================================
+ Coverage    66.09%   77.65%   +11.56%     
============================================
  Files          990      185      -805     
  Lines       115462    25053    -90409     
  Branches      5750      481     -5269     
============================================
- Hits         76311    19456    -56855     
+ Misses       37715     5590    -32125     
+ Partials      1436        7     -1429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 6d9c234 into misskey-dev:develop Mar 12, 2024
16 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 12, 2024

🙏

@anatawa12 anatawa12 deleted the preview-popup-of-local-link branch May 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants