Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 自分のノートの添付ファイルから直接ファイルの詳細ページに飛べるようにする #13520

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 自分のノートの添付ファイルから直接ファイルの詳細ページに飛べるようにするメニューを追加
  • ファイルをpackする際に、ユーザー情報を含むかどうかに関わらずユーザーIDを含むように(フロントエンド側で自分のファイルかどうかの判定をするのが大変だったのではじめから含むようにしたけどもうちょっとマシな方法にすべきかも)

Why

Fix #13519

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.90%. Comparing base (f8261a1) to head (7cb8533).
Report is 445 commits behind head on develop.

Files Patch % Lines
...ackend/src/core/entities/DriveFileEntityService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13520       +/-   ##
============================================
- Coverage    79.95%   60.90%   -19.05%     
============================================
  Files          956      801      -155     
  Lines       108864    85784    -23080     
  Branches      8413     3908     -4505     
============================================
- Hits         87045    52251    -34794     
- Misses       21819    33506    +11687     
- Partials         0       27       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review March 5, 2024 04:10
@syuilo
Copy link
Member

syuilo commented Mar 5, 2024

CHNGELOG要るかも

@syuilo syuilo merged commit 08d618b into misskey-dev:develop Mar 5, 2024
5 of 7 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 5, 2024

👍

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Thank you for sending us a great Pull Request! 👍
Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types

@kakkokari-gtyih kakkokari-gtyih deleted the enh-13519 branch March 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自分のノートの添付ファイルから直接ファイルの詳細ページに飛べるようにする
2 participants