enhance: Use SI prefixes for job queue widget, extends bytes #12896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12896 +/- ##
===========================================
- Coverage 79.95% 79.95% -0.01%
===========================================
Files 956 954 -2
Lines 108864 108876 +12
Branches 8413 8448 +35
===========================================
+ Hits 87045 87047 +2
- Misses 21819 21829 +10 ☔ View full report in Codecov by Sentry. |
|
lintエラーになってるわね |
|
あー持ってきた元が古かったわ。直したのだわ。 |
|
🙏 |
u1-liquid
pushed a commit
to MisskeyIO/misskey
that referenced
this pull request
Jan 5, 2024
…-dev#12896) * Use SI prefixes for job queue widget * a * bytes * lint
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Jan 5, 2024
…-dev#12896) (#328) Co-authored-by: MeiMei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use SI prefixes for job queue widget.
Also, after Q (10^30), the exponent.
The tooltip still provides the actual value.
Also expands the bytes prefix.
Why
Additional info (optional)
Checklist