feat(frontend): 投稿ウインドウにMFM要素を追加するボタンの追加 #12788
Merged
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12788 +/- ##
===========================================
- Coverage 81.91% 81.80% -0.12%
===========================================
Files 180 181 +1
Lines 27526 27599 +73
Branches 511 511
===========================================
+ Hits 22549 22577 +28
- Misses 4977 5022 +45 ☔ View full report in Codecov by Sentry. |
|
MFMによる装飾は隠し機能的な感じだから当該ボタンの表示はオプトインで良い気がするわね |
|
(デフォルトでは動きのあるMFMの表示はオフになってるし) |
|
了解です！デフォルトは非表示にして、設定に本機能の表示/非表示の設定を設けてみます。 |
samunohito
reviewed
Dec 25, 2023
samunohito
reviewed
Dec 25, 2023
|
デフォルトはOFFで、下記のような設定項目を追加しました。 |
samunohito
approved these changes
Dec 25, 2023
syuilo
reviewed
Dec 27, 2023
There was a problem hiding this comment.
a7026ee で function を mfm function に統一しました
|
lintの警告が多く出てますので直していただければ 🙏🏻 |
|
8eb3f6a で4スペースのインデントになっている個所を1タブに変更しました🙇♂️ |
|
👍🏻 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* functionPicker の追加 * Update CHANGELOG.md * fix lint errors * Add addMfmFunction * add enableQuickAddMfmFunction setting * Update CHANGELOG.md issue 番号を追加 * Update index.d.ts * change 'functionPicker' to 'mfmFunctionPicker' * Change indent from 4 space to 1 tab --------- Co-authored-by: syuilo <[email protected]>
madonuko
pushed a commit
to FyraLabs/nyaakey
that referenced
this pull request
Feb 26, 2024
* functionPicker の追加 * Update CHANGELOG.md * fix lint errors * Add addMfmFunction * add enableQuickAddMfmFunction setting * Update CHANGELOG.md issue 番号を追加 * Update index.d.ts * change 'functionPicker' to 'mfmFunctionPicker' * Change indent from 4 space to 1 tab --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
投稿ウインドウにMFM要素を追加するボタンを追加して、カーソルの位置にMFM要素を追加できるようにします。
加えて、選択範囲を指定しているときにMFM要素を追加すると選択範囲を囲むようにMFM要素が追加されるようにします。
Why
#12787
Additional info (optional)
$[Fn ]が追加されること$[Fn :hoge:]と補完されることChecklist