Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): import宣言周りのエラーを修正 #12773

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

zyoshoka
Copy link
Contributor

What

フロントエンドで用いられている import 宣言周りで TypeScript コンパイラがエラーを吐いている箇所を修正しました。

Why

フロントエンドにおけるエラー解消の一環

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (471c8ec) 79.79% compared to head (c46f514) 81.92%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12773      +/-   ##
===========================================
+ Coverage    79.79%   81.92%   +2.13%     
===========================================
  Files          956      180     -776     
  Lines       108800    27502   -81298     
  Branches      8373      511    -7862     
===========================================
- Hits         86814    22532   -64282     
+ Misses       21986     4970   -17016     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 0009aa3 into misskey-dev:develop Dec 24, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 24, 2023

🙏🏻

@zyoshoka zyoshoka deleted the correct-imports branch December 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants