Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: api.jsonのレスポンスの内容を実際の内容に合わせる #12723

Merged
merged 36 commits into from
Dec 21, 2023

Conversation

GrapeApple0
Copy link
Contributor

@GrapeApple0 GrapeApple0 commented Dec 20, 2023

What

レスポンスがあるがapi.jsonには書かれていないものを修正します

Why

api.jsonの正確性を上げるため

Additional info (optional)

returnの型から推測して書いています。
もし違っていたらすいません

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07d4632) 81.91% compared to head (6a5047b) 81.91%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12723   +/-   ##
========================================
  Coverage    81.91%   81.91%           
========================================
  Files          180      180           
  Lines        27475    27475           
  Branches       511      511           
========================================
  Hits         22505    22505           
  Misses        4970     4970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrapeApple0 GrapeApple0 changed the title [wip]enhance: api.jsonのレスポンスの内容を実際の内容に合わせる enhance: api.jsonのレスポンスの内容を実際の内容に合わせる Dec 21, 2023
@GrapeApple0 GrapeApple0 marked this pull request as ready for review December 21, 2023 07:43
@syuilo syuilo merged commit 79ca93c into misskey-dev:develop Dec 21, 2023
15 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 21, 2023

🙏🙏🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* Create packedAdSchema

* admin/emoji/add

* admin/get-user-ips

* admin/roles/users

* admin/get-index-stats

* admin/accounts/find-by-email

* fix type of admin/ad/list

* federation/stats

* endpoints

* get-online-users-count

* i/2fa/register-key

* i/2fa/key-done

* i/2fa/register

* i/apps

* i/authorized-apps

* i/registry/get-all

* i/registry/get

* i/registry/get-detail

* i/registry/key-with-type

* i/registry/scopes-with-domain

* i/update-email

* i/move

* i/webhooks/create

* fix miss type

* i/webhooks/show

* i/webhooks/list

* flash/create

* roles/users

* server-info

* test

* users/lists/get-memberships

* users/achievements

* fetch-rss

* fetch-external-resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants