Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Renoteの判定が間違っているのを修正 #12706

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

1Step621
Copy link
Contributor

What

投票のみ/画像のみの引用RNが、通知欄でただのRNとして判定されるバグを修正しました。
CWをつけて引用RNしても、普通のRNとして扱われてしまうバグを修正しました。

Why

Resolve #11222
Resolve #12284

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38b82b8) 79.68% compared to head (7a3a077) 81.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12706      +/-   ##
===========================================
+ Coverage    79.68%   81.86%   +2.18%     
===========================================
  Files          955      180     -775     
  Lines       107863    27519   -80344     
  Branches      8351      507    -7844     
===========================================
- Hits         85948    22529   -63419     
+ Misses       21915     4990   -16925     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit f6ff3b1 into misskey-dev:develop Dec 18, 2023
16 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 18, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* RNと引用RNの判定が間違っているのを修正

* remove dump.rdb

* update CHANGELOG.md

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
2 participants