-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: “つながりの公開範囲”がフォロー・フォロワー個別設定できるように #12702
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12702 +/- ##
===========================================
+ Coverage 79.65% 81.74% +2.09%
===========================================
Files 955 178 -777
Lines 107713 27337 -80376
Branches 8351 511 -7840
===========================================
- Hits 85796 22347 -63449
+ Misses 21917 4990 -16927 ☔ View full report in Codecov by Sentry. |
|
わかりました、この部分は差し戻します
ア! |
修正しました |
locales/ja-JP.yml
Outdated
ffVisibility: "つながりの公開範囲" | ||
ffVisibilityDescription: "自分のフォロー/フォロワー情報の公開範囲を設定できます。" | ||
followingVisibility: "フォローの公開範囲" | ||
followingVisibilityDescription: "自分のフォロー情報の公開範囲を設定できます。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「つながり」から「フォロー/フォロワー」と具体的な呼称に変わったから特にdescriptionは要らなそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうですね、消しちゃいましょう
locales/ja-JP.yml
Outdated
followingVisibility: "フォローの公開範囲" | ||
followingVisibilityDescription: "自分のフォロー情報の公開範囲を設定できます。" | ||
followersVisibility: "フォロワーの公開範囲" | ||
followersVisibilityDescription: "自分のフォロワー情報の公開範囲を設定できます。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
名称が具体的になって必要なくなったため misskey-dev#12702 (comment)
👍👍 |
* Enhance: “つながりの公開範囲”がフォロー・フォロワー個別設定できるように (misskey-dev#12072) * refactor: crowdin 編集部分のコミットを打ち消し misskey-dev#12702 (comment) * refactor: オブジェクトの名前修正 misskey-dev#12702 (comment) * fix: 設定項目の説明を削除 名称が具体的になって必要なくなったため misskey-dev#12702 (comment)
What
このPRは「つながりの公開範囲」をフォロー/フォロワーで個別に設定できるようになります。
Why
このPRは #12072 を解決することができます。 (Resolve #12072)
Additional info (optional)
Checklist