Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): コード入力ボックスをMkCodeEditorに変更 #12682

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 16, 2023

What

  • コード入力の部分をMkCodeEditorに変更し、シンタックスハイライトが効くようにした
  • MkCodeEditorにMkTextareaと同様の機能を実装
  • MkCodeEditorの入力がズレる問題を修正

Why

#9856 #12671

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e256ee) 79.68% compared to head (726d56c) 79.66%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12682      +/-   ##
===========================================
- Coverage    79.68%   79.66%   -0.02%     
===========================================
  Files          960      959       -1     
  Lines       108573   108509      -64     
  Branches      8351     8350       -1     
===========================================
- Hits         86513    86449      -64     
  Misses       22060    22060              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 1706541 into misskey-dev:develop Dec 16, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 16, 2023

👍

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
@kakkokari-gtyih kakkokari-gtyih deleted the enh-12671 branch March 11, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants