Enhance(frontend): MFMや絵文字が使える入力ボックスでオートコンプリートを使えるように #12643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Step621
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12643 +/- ##
===========================================
+ Coverage 79.68% 81.91% +2.22%
===========================================
Files 959 184 -775
Lines 108404 28282 -80122
Branches 8345 503 -7842
===========================================
- Hits 86381 23167 -63214
+ Misses 22023 5115 -16908 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Dec 13, 2023
syuilo
reviewed
Dec 13, 2023
syuilo
reviewed
Dec 13, 2023
メンションなども「MFM」に含まれるのか自信がなかったのでrichSyntaxなどとぼかしていましたが、含むようなので変更しました
|
ちょっと調整 |
|
👍🏻 👍🏻 |
|
ありがとうございます！🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
) * rich autocomplete for use in profiles, announcements, and channel descriptions * implementation omissions * add tab, apply to page editor, and fix something * componentization * fix nyaize doesn't working in profile preview * detach autocomplete instance when unmounted * fix: mismatched camelCase * remove unused / unnecessary styles * update CHANGELOG.md * fix lint * remove dump.rdb * props.richAutocomplete -> autocomplete * Update packages/frontend/src/scripts/autocomplete.ts * clarify namings メンションなども「MFM」に含まれるのか自信がなかったのでrichSyntaxなどとぼかしていましたが、含むようなので変更しました * tweak * Update MkFormDialog.vue * rename --------- Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ユーザー名・プロフィール・お知らせ・ページのテキストブロックの4箇所でオートコンプリートを使えるようにしました。うち、プロフィール・お知らせではプレビューも見られるようにしました。
Why
入力が楽になると同時に、「ここでは絵文字/MFMが使える」とユーザーに知らせる役割も果たせると思います。
Related: #12597
Additional info (optional)
Screencast.from.2023.12.13.16.41.00.webm
Screencast.from.2023.12.13.16.41.41.webm
Screencast.from.2023.12.13.16.42.31.webm
Screencast.from.2023.12.13.16.43.36.webm
Checklist