Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(backend): inboxJobPerSecのデフォルト値を16から32に #12631

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

camilla-ett
Copy link
Contributor

@camilla-ett camilla-ett commented Dec 12, 2023

What

ジョブの配送頻度のデフォルト設定を倍にしました。

Why

関連
#11000

https://kasei.ski/ でジョブキューのつまりが一カ月くらい詰まっており、inboxJobPerSec の値を128に変更した所詰まりが一気に解消された。

↓変更前の状態
https://kasei.ski/notes/9n4dnh9jin

その後、試験用の環境(https://dev.kasei.ski/ )で検証した結果、deliverに対してinboxのデフォルト値が小さすぎると感じたので、一旦32まで上げるPRを用意した(deliver:inbox のデフォルトの割合は1:1 でもいいんじゃないかなと思う)

Additional info (optional)

MisskeyHubに記載を増やす?でも良いかもしれないのですが、記載先が分からなかったので一旦本体向けにPRを用意しました 🙏

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 12, 2023
@camilla-ett camilla-ett marked this pull request as ready for review December 12, 2023 01:39
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ded328f) 78.80% compared to head (a457dfd) 79.63%.
Report is 116 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12631      +/-   ##
===========================================
+ Coverage    78.80%   79.63%   +0.83%     
===========================================
  Files          948      957       +9     
  Lines       102884   108216    +5332     
  Branches      8285     8348      +63     
===========================================
+ Hits         81077    86179    +5102     
- Misses       21807    22037     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 06ca63f into misskey-dev:develop Dec 12, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 12, 2023

🙏

@camilla-ett camilla-ett deleted the inboxJobPerSec branch December 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants