Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: labelerが治っていなかったのを修正 #12610

Merged
merged 4 commits into from
Dec 9, 2023

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Dec 8, 2023

What

#12609 のパッチが正しく動作していなかったのを修正しました。

Why

Additional info (optional)

zyoshoka#3 で実際に変更を加えたときラベルが貼られるのを確認しました。度々になって申し訳ないです🙏

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c6fc0b) 79.59% compared to head (81dd32e) 81.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12610      +/-   ##
===========================================
+ Coverage    79.59%   81.53%   +1.94%     
===========================================
  Files          959      183     -776     
  Lines       108253    28033   -80220     
  Branches      8337      497    -7840     
===========================================
- Hits         86167    22858   -63309     
+ Misses       22086     5175   -16911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito
Copy link
Member

samunohito commented Dec 9, 2023

Pull Request Labeler / triage (pull_request_target) Failing after 3s

差分も拝見しましたが、設定内容には問題なさそうです(文法エラーとかも無さそう)
…が、何故こちらのCIはfailになってしまっているのか…

(labelerの条件に合致するものがないと失敗扱いになる…?)

@samunohito
Copy link
Member

申し訳ないです、自分のforkでも試そうと思ったらpush先を間違えてしまって…
コミットはrevert済みです

@syuilo
Copy link
Member

syuilo commented Dec 9, 2023

Pull Request Labeler / triage (pull_request_target) Failing after 3s

差分も拝見しましたが、設定内容には問題なさそうです(文法エラーとかも無さそう) …が、何故こちらのCIはfailになってしまっているのか…

(labelerの条件に合致するものがないと失敗扱いになる…?)

develop側の設定が使われてると思う

@samunohito
Copy link
Member

なんと…ブランチの内容を使うものかと思っていました

@syuilo syuilo merged commit 6c1f839 into misskey-dev:develop Dec 9, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 9, 2023

🙏

@zyoshoka zyoshoka deleted the fix-fix-labeler-config branch December 9, 2023 02:35
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix ci

* fix

* fix labeler.yml

* Revert "fix labeler.yml"

This reverts commit 9b6a7d0.

---------

Co-authored-by: samunohito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants