Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend) pnpm dev でフロントエンドが起動できない問題を修正 #12566

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

samunohito
Copy link
Member

What

#12528 の対応(リテイク)です。
この対応によりpnpm devでMisskeyを立ち上げることができます。

Why

フロントエンド側がエラーとなっており起動できない

Additional info (optional)

ブラウザのキャッシュを全消しした後に以下のコマンドでそれぞれビルド&起動し、
テーマエディタを開いてライト・ダークの切り替えおよびテーマの切り替えを試し、コンソールにエラーが出ないこと、テーマが切り替わることを確認しました。

  • pnpm build && pnpm start
  • pnpm dev

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md ※ユーザ影響はないので書いていません
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55c8ec8) 78.74% compared to head (4d17559) 78.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12566      +/-   ##
===========================================
- Coverage    78.74%   78.37%   -0.38%     
===========================================
  Files          954      181     -773     
  Lines       103825    23927   -79898     
  Branches      8351      497    -7854     
===========================================
- Hits         81758    18752   -63006     
+ Misses       22067     5175   -16892     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit b2c4973 into misskey-dev:develop Dec 4, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 4, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
@samunohito samunohito deleted the fix/fix_dev_build branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants