fix(backend): reject malformed timestamp #12554
Merged
+49
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-chicken
added
🐛Bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12554 +/- ##
===========================================
- Coverage 78.79% 78.76% -0.04%
===========================================
Files 954 953 -1
Lines 103756 103735 -21
Branches 8346 8348 +2
===========================================
- Hits 81756 81707 -49
- Misses 22000 22028 +28 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
syuilo
reviewed
Dec 3, 2023
| @@ -306,9 +306,15 @@ export class ApInboxService { | |||
| this.logger.info(`Creating the (Re)Note: ${uri}`); | |||
|
|
|||
| const activityAudience = await this.apAudienceService.parseAudience(actor, activity.to, activity.cc); | |||
| const createdAt = activity.published ? new Date(activity.published) : null; | |||
|
|
|||
| if (createdAt && createdAt < this.idService.parse(renote.id).date) { | |||
There was a problem hiding this comment.
Renote の Note ID が同様の問題を発生させる可能性がある
そもそも Renote が参照先の Note より先に発行されるはずはないため、そういう条件で判定している
There was a problem hiding this comment.
まぁリモートのサーバーの時計がぶっ壊れてたらここに到達する可能性は否めないが、それは NTP 設定してくれ〜すぎるので
|
🙏🏻 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
リモートの Activity のタイムスタンプによってタイムスタンプ部がクランプされる ID が生成されるとき、その Activity を拒否する
Why
Fix #12401
Additional info (optional)
Checklist