Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #12544 #12545

Merged
merged 4 commits into from
Dec 2, 2023
Merged

fix: #12544 #12545

merged 4 commits into from
Dec 2, 2023

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Dec 2, 2023

What

#12544 の対応です。
この対応により、STLでフォロワー限定投稿を閲覧できるようになります

Why

fix #12544

Additional info (optional)

ローカルにて動作確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (238e8ce) 78.71% compared to head (f195c2c) 78.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12545      +/-   ##
===========================================
- Coverage    78.71%   78.45%   -0.27%     
===========================================
  Files          951      180     -771     
  Lines       103427    23836   -79591     
  Branches      8330      496    -7834     
===========================================
- Hits         81417    18701   -62716     
+ Misses       22010     5135   -16875     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@samunohito
Copy link
Member Author

@syuilo
さきほどマージされた #12507 の対応漏れと思われるので、見ていただけると… 🙏

@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

2023.11.1で発生してなければCHANGELOGは不要かも

@samunohito
Copy link
Member Author

お。じゃあCHANGELOGだけ戻します

This reverts commit aaee4e9.
@syuilo syuilo merged commit 92029ac into misskey-dev:develop Dec 2, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

🙏🏻

@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

フォロワー限定投稿が見れなくなっていたのにテストが落ちなかったのは悲しいわね
ケースが抜けてるのかしら

@samunohito
Copy link
Member Author

いまのテストを見てきましたが、ノートが含まれている/含まれていないのみに観点が絞られていたので、それかなと
今回はノートそのものが含まれている状態で、その中のフラグ設定(isHidden)に問題があったので

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* meを渡し忘れている

* fix CHANGELOG.md

* Revert "fix CHANGELOG.md"

This reverts commit aaee4e9.
@samunohito samunohito deleted the fix/fix_forgot_me branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STLに流れてきたフォロワー限定投稿が(非公開)になってしまう
2 participants