Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing receiver warn is not disappear #12538

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

qwreey
Copy link
Contributor

@qwreey qwreey commented Dec 1, 2023

What

Make 'missing receiver warn' disappearing appropriately

2023-12-02.08-30-08.mp4

Why

'This note contains mentions of users not included as recipients' warn should disappear when note visibility was changed. but not disappear even visibility is public

2023-12-02.08-30-35.mp4

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cd4c36) 78.64% compared to head (bef1cff) 78.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12538      +/-   ##
===========================================
+ Coverage    78.64%   78.68%   +0.04%     
===========================================
  Files          950      952       +2     
  Lines       103297   103488     +191     
  Branches      8330     8331       +1     
===========================================
+ Hits         81238    81431     +193     
+ Misses       22059    22057       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit c927d68 into misskey-dev:develop Dec 2, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants