Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: フォローしたときにHTLをパージしなくする #12522

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Nov 30, 2023

What

フォローしたときにHTLをパージしなくします。

副作用で Fixes #12513

Why

#12065 (comment)

長くTLをさかのぼったときのみであれば影響は小さいと思いますが、フォロー時にHTLのキャッシュがフォロー時に消えることで直近でも影響があるので直してほしい感じです。特にリプが一切表示されなくなるのではなくSTLの場合にはSTLの(LTL成分向けの)withRepliesをすべてに適用するという形でもいいので何かしら対策してほしいです。

DB fallbackでwithRepliesが一切機能しないので、一瞬でも遡ろうとするとリプライが消える不具合になるため。
フォローする前のツイートが表示されないほうが自然な仕様だと思います。

#12065 (comment)

purgeするのをやめた方がいいな

とsyuiloさんがおっしゃっていたのでやるのだと思ってましたが未実装だったのでPR作りました

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 30, 2023
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca424df) 78.64% compared to head (047b37c) 78.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12522      +/-   ##
===========================================
- Coverage    78.64%   78.64%   -0.01%     
===========================================
  Files          950      950              
  Lines       103297   103293       -4     
  Branches      8330     8330              
===========================================
- Hits         81238    81234       -4     
  Misses       22059    22059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit da0ecb6 into misskey-dev:develop Dec 2, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

🙏

@anatawa12 anatawa12 deleted the remove-purging-htl-on-follow branch March 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

フォロー後、特定条件下でSTLのHTL相当のノートが消える(表示できなくなる)
2 participants