Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invite系の戻り値が間違っている #12518

Merged

Conversation

yupix
Copy link
Contributor

@yupix yupix commented Nov 30, 2023

What

#12517 を解決します

Why

ドキュメントに正確な戻り値を表示する為

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 30, 2023
@syuilo syuilo merged commit ca424df into misskey-dev:develop Nov 30, 2023
12 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 30, 2023

🙏

@yupix yupix deleted the feat/using-ref-for-invite-responses branch November 30, 2023 06:56
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -7845,16 +7845,7 @@
                   "items": {
                     "type": "object",
                     "nullable": false,
-                    "properties": {
-                      "code": {
-                        "type": "string",
-                        "nullable": false,
-                        "example": "GR6S02ERUA5VR"
-                      }
-                    },
-                    "required": [
-                      "code"
-                    ]
+                    "$ref": "#/components/schemas/InviteCode"
                   }
                 }
               }
@@ -8045,7 +8036,8 @@
                   "nullable": false,
                   "items": {
                     "type": "object",
-                    "nullable": false
+                    "nullable": false,
+                    "$ref": "#/components/schemas/InviteCode"
                   }
                 }
               }
@@ -41078,16 +41070,7 @@
                 "schema": {
                   "type": "object",
                   "nullable": false,
-                  "properties": {
-                    "code": {
-                      "type": "string",
-                      "nullable": false,
-                      "example": "GR6S02ERUA5VR"
-                    }
-                  },
-                  "required": [
-                    "code"
-                  ]
+                  "$ref": "#/components/schemas/InviteCode"
                 }
               }
             }
@@ -41437,7 +41420,8 @@
                   "nullable": false,
                   "items": {
                     "type": "object",
-                    "nullable": false
+                    "nullable": false,
+                    "$ref": "#/components/schemas/InviteCode"
                   }
                 }
               }

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants