Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use refs/pull/*/merge to get head api.json #12508

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

anatawa12
Copy link
Member

What

API.jsonを取得するときにrefs/pull/*/mergeを使用するようにします。

Why

baseの変更に起因するapi.jsonのdiffが発生しなく(しづらく)なります。

baseの変更に起因するapi.jsonの例: #12507 (comment)

developとの分岐点を #12507 と同じところにしたので多分二つで比較できると思います

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e5b776) 78.68% compared to head (1666938) 78.64%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12508      +/-   ##
===========================================
- Coverage    78.68%   78.64%   -0.05%     
===========================================
  Files          951      949       -2     
  Lines       103427   103240     -187     
  Branches      8329     8328       -1     
===========================================
- Hits         81385    81195     -190     
- Misses       22042    22045       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit c41d030 into misskey-dev:develop Nov 29, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 29, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
@anatawa12 anatawa12 deleted the use-merged-to-get-api-json branch March 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants