Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: navigator.share未サポートの場合は共有ボタンを非表示にする(+URLのコピーボタンを設置) #12506

Merged

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Nov 29, 2023

What

#11305 の対応です。
この対応により、以下が適用されます。

  • チャンネル、クリップ、ページ、Play、ギャラリーにURLのコピーボタンが増える
  • navigator.shareに対応していないブラウザでは共有ボタンやメニューが非表示になる

Why

fix #11305

Additional info (optional)

以下の画面をPC版FirefoxとChromeで表示し、共有ボタンの表示有無を確認

  • TLのノート三点リーダークリックで出るメニュー
  • ノート詳細表示時の三点リーダーで出るメニュー
  • チャンネル
  • クリップ
  • ページ
  • Play
  • ギャラリー

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 29, 2023
@samunohito samunohito marked this pull request as ready for review November 29, 2023 12:46
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (37cff40) 78.63% compared to head (9a71357) 78.30%.

Files Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 25.00% 3 Missing ⚠️
packages/frontend/src/scripts/navigator.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12506      +/-   ##
===========================================
- Coverage    78.63%   78.30%   -0.34%     
===========================================
  Files          949      179     -770     
  Lines       103240    23641   -79599     
  Branches      8327      496    -7831     
===========================================
- Hits         81186    18512   -62674     
+ Misses       22054     5129   -16925     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito changed the title Fix: navigator.share未サポートの場合は共有ボタンを非表示にする [WIP] Fix: navigator.share未サポートの場合は共有ボタンを非表示にする Nov 29, 2023
@samunohito samunohito marked this pull request as draft November 29, 2023 13:15
@samunohito samunohito changed the title [WIP] Fix: navigator.share未サポートの場合は共有ボタンを非表示にする Fix: navigator.share未サポートの場合は共有ボタンを非表示にする(+URLのコピーボタンを設置) Nov 29, 2023
@samunohito samunohito marked this pull request as ready for review November 29, 2023 23:05
@syuilo syuilo merged commit 413f7bf into misskey-dev:develop Nov 29, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 29, 2023

👍

Sayamame-beans pushed a commit to Sayamame-beans/misskey that referenced this pull request Nov 30, 2023
…v#12506)

* navigator.share未サポートの場合は共有ボタンを非表示にする

* fix CHANGELOG.md

* ライセンス表示追加

* URLのコピーボタンを設置
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
…v#12506)

* navigator.share未サポートの場合は共有ボタンを非表示にする

* fix CHANGELOG.md

* ライセンス表示追加

* URLのコピーボタンを設置
@samunohito samunohito deleted the fix/11305_hide_unsupported_share_buttons branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FirefoxでClipの共有ボタンが機能しない
2 participants