-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: navigator.share未サポートの場合は共有ボタンを非表示にする(+URLのコピーボタンを設置) #12506
Merged
syuilo
merged 6 commits into
misskey-dev:develop
from
samunohito:fix/11305_hide_unsupported_share_buttons
Nov 29, 2023
Merged
Fix: navigator.share未サポートの場合は共有ボタンを非表示にする(+URLのコピーボタンを設置) #12506
syuilo
merged 6 commits into
misskey-dev:develop
from
samunohito:fix/11305_hide_unsupported_share_buttons
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12506 +/- ##
===========================================
- Coverage 78.63% 78.30% -0.34%
===========================================
Files 949 179 -770
Lines 103240 23641 -79599
Branches 8327 496 -7831
===========================================
- Hits 81186 18512 -62674
+ Misses 22054 5129 -16925 ☔ View full report in Codecov by Sentry. |
samunohito
changed the title
Fix: navigator.share未サポートの場合は共有ボタンを非表示にする
[WIP] Fix: navigator.share未サポートの場合は共有ボタンを非表示にする
Nov 29, 2023
samunohito
changed the title
[WIP] Fix: navigator.share未サポートの場合は共有ボタンを非表示にする
Fix: navigator.share未サポートの場合は共有ボタンを非表示にする(+URLのコピーボタンを設置)
Nov 29, 2023
👍 |
Sayamame-beans
pushed a commit
to Sayamame-beans/misskey
that referenced
this pull request
Nov 30, 2023
…v#12506) * navigator.share未サポートの場合は共有ボタンを非表示にする * fix CHANGELOG.md * ライセンス表示追加 * URLのコピーボタンを設置
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
…v#12506) * navigator.share未サポートの場合は共有ボタンを非表示にする * fix CHANGELOG.md * ライセンス表示追加 * URLのコピーボタンを設置
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#11305 の対応です。
この対応により、以下が適用されます。
Why
fix #11305
Additional info (optional)
以下の画面をPC版FirefoxとChromeで表示し、共有ボタンの表示有無を確認
Checklist